-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reboot_gateway service to Velux #43198
Conversation
Hey there @Julius2342, mind taking a look at this pull request as its been labeled with an integration ( |
Yes, this is a useful improvement to work around KLF200 difficulties. And it looks sane. (Im not much into the hass codebase at the moment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposes a newly added feature of pyvlx as a service. Useful, because the KLF200 has a tendency to stop accepting new connections after some time.
This was split out of #42773 to reduce complexity.
Hi home-assistant team, is there anything which blocks merging this PR? |
This comment has been minimized.
This comment has been minimized.
Not stale, awaiting our review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is fine ✅
However, it needs a documentation update to list this service. Please open a PR on our documentation and link it with this PR.
@frenck I created a PR for documentation: https://github.com/home-assistant/home-assistant.io/pull/16352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pawlizio 👍
Proposed change
Provides a workaround for #34844 by adding a reboot service for the KLF200 gateway which can be integrated in automations. Most likely:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: